Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add copy button when creating new application password Fix/62019 #7382

Open
wants to merge 7 commits into
base: trunk
Choose a base branch
from
Open

Add copy button when creating new application password Fix/62019 #7382

wants to merge 7 commits into from
+40 −4

Conversation

circlecube
Copy link

Trac ticket: https://core.trac.wordpress.org/ticket/62019

Updating the existing patch to capitalize the button text 'copy > 'Copy' and making the text translatable.

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props circlecube, jeremyfelt.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions GitHub Actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

circlecube and others added 2 commits September 17, 2024 18:36
@circlecube @jeremyfelt
Update src/js/_enqueues/admin/user-profile.js
18b6243 
Co-authored-by: Jeremy Felt <[email protected]>
@circlecube
Merge branch 'trunk' into fix/62019
7ddbc19 
* trunk:
  Build Tools: Allow easier customization of the .env file.
  Coding Standards: Avoid using confusing `!` condition in Media Library selection check.
  REST API: Only check password value in query parameters while checking post permissions.
  Media: Add Ctrl/Command + Enter shortcut to insert selected Media Library items.
  REST API: Support exact search in the REST API posts endpoint.
  Script Loader: Remove unused array_merge.
  REST API: Automatically populate targetHints for the Allow header.
@circlecube circlecube changed the title Fix/62019 Add copy button when creating new application password Fix/62019 Sep 17, 2024
@jeremyfelt
Copy link
Member

Things are looking good so far, @circlecube, thanks!

A couple more notes:

  1. We should apply these changes to wp-admin/profile.php as well. I think folks are more likely to be adding application passwords through that screen rather than while editing another user.
  2. We can probably add a bit of spacing above "Copy" on mobile. (See screenshot)

CleanShot 2024-09-17 at 15 42 28@2x

@circlecube
Copy link
Author

circlecube commented Sep 17, 2024 •
edited
Loading

  1. We should apply these changes to wp-admin/profile.php as well. I think folks are more likely to be adding application passwords through that screen rather than while editing another user.

The wp-admin/profile.php file loads up wp-admin/user-edit/php i.e. these changes are on the profile page now.

  1. We can probably add a bit of spacing above "Copy" on mobile.

Good catch @jeremyfelt, looking at this now.

@jeremyfelt
Copy link
Member

The wp-admin/profile.php file loads up wp-admin/user-edit/php i.e. these changes are on the profile page now.

Ha! I swear this was not working, but there it is. My fault!

@circlecube
adjust spacing between input and copy button
623dce8 
(this only applies in some small screen sizes when this wraps into multiple lines)
@circlecube
Copy link
Author

Screenshots of the mobile layout with a tiny CSS tweak:
application-secret-copy-mobile-small
application-secret-copy-mobile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyfelt jeremyfelt Awaiting requested review from jeremyfelt

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@circlecube @jeremyfelt